-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8, autopep8, and pycln to CI #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
- Coverage 84.61% 84.60% -0.02%
==========================================
Files 51 51
Lines 2061 2059 -2
==========================================
- Hits 1744 1742 -2
Misses 317 317
Continue to review full report at Codecov.
|
auvipy
reviewed
Oct 12, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Will manually resolve the following tomorrow silk/models.py:5:1: F401 'collections.Counter' imported but unused
silk/models.py:11:1: F401 'django.db.models.F' imported but unused
project/tests/test_code_gen_curl.py:6:1: F401 'json' imported but unused
project/tests/test_code_gen_curl.py:7:1: F401 'subprocess' imported but unused
project/tests/test_code_gen_curl.py:8:1: F401 'unittest' imported but unused
project/tests/test_code_gen_curl.py:11:1: F401 'silk.code_generation.curl.curl_cmd' imported but unused
project/tests/test_view_profiling.py:1:1: F401 'random' imported but unused
project/tests/test_db.py:20:9: F841 local variable 'objects' is assigned to but never used
project/tests/test_db.py:30:9: F841 local variable 'profile' is assigned to but never used
project/tests/test_db.py:39:9: F841 local variable 'objects' is assigned to but never used
project/tests/test_db.py:55:9: F841 local variable 'profile' is assigned to but never used
project/tests/test_code.py:12:34: E741 ambiguous variable name 'l'
project/tests/test_execute_sql.py:7:1: F401 'silk.sql.connection' imported but unused
silk/views/cprofile.py:6:1: F401 'silk.models.Profile' imported but unused
silk/views/cprofile.py:7:1: F401 'silk.views.code._code_context' imported but unused
silk/views/cprofile.py:7:1: F401 'silk.views.code._code_context_from_request' imported but unused
silk/profiling/dynamic.py:5:1: F401 'functools.partial' imported but unused
project/gen.py:7:5: F841 local variable 'venetian' is assigned to but never used
project/gen.py:8:5: F841 local variable 'roller' is assigned to but never used
silk/templatetags/silk_filters.py:73:12: E741 ambiguous variable name 'l'
project/tests/test_profile_dot.py:55:13: E704 multiple statements on one line (def)
project/tests/test_profile_dot.py:80:36: F841 local variable 'filename' is assigned to but never used
project/tests/test_models.py:92:5: F811 redefinition of unused 'test_time_spent_on_sql_queries_if_has_related_SQLQueries_and_time_taken' from line 84
silk/middleware.py:30:1: E704 multiple statements on one line (def)
project/tests/__init__.py:1:1: F403 'from . import *' used; unable to detect undefined names
project/tests/__init__.py:1:1: F401 'from . import *' imported but unused
silk/model_factory.py:159:13: E722 do not use bare 'except'
project/tests/test_lib/mock_suite.py:1:1: F401 'calendar' imported but unused
project/example_app/tests.py:1:1: F401 'django.test.TestCase' imported but unused
project/tests/test_silky_middleware.py:1:1: F401 'unittest.mock.Mock' imported but unused
project/tests/test_sensitive_data_in_request.py:7:1: F401 'silk.model_factory.ResponseModelFactory' imported but unused |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Archmonger
changed the title
Add flake8 and autopep8 to CI
Add flake8, autopep8, and pycln to CI
Oct 13, 2021
This reverts commit 2c56921.
This reverts commit 5f42c17.
for more information, see https://pre-commit.ci
This reverts commit 1e9c7c4.
for more information, see https://pre-commit.ci
auvipy
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in PEP8 conformity throughout the repo.
New CI hooks
flake8
: Provides error messages for PEP8 violationsautopep8
: Automatically fixes most PEP8 violationspycln
: Automatically fixes PEP8 unused imports violations