Django main #528
Merged
Django main #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 51 51
Lines 2059 2059
=======================================
Hits 1742 1742
Misses 317 317
Continue to review full report at Codecov.
|
jezdez
requested changes
Nov 24, 2021
silk/profiling/profiler.py
Outdated
| @@ -102,7 +102,7 @@ def __enter__(self): | |||
| 'start_time': timezone.now(), | |||
| } | |||
| else: | |||
| Logger.warn('Cannot execute silk_profile as silk is not installed correctly.') | |||
| Logger.warning('Cannot execute silk_profile as silk is not installed correctly.') | |||
There was a problem hiding this comment.
Good catch! Could we rename the variable to logger, too?
| @@ -1,7 +1,7 @@ | |||
| from django.conf.urls import include, url | |||
| from django.urls import include, path | |||
There was a problem hiding this comment.
Suggested change
| from django.urls import include, path | |
| from django.urls import include, re_path |
|
|
||
| urlpatterns = [ | ||
| url( | ||
| path( |
jezdez
requested changes
Nov 24, 2021
hramezani
force-pushed
the
django_main
branch
from
7728907
to
94e76a5
Compare
hramezani
force-pushed
the
django_main
branch
from
94e76a5
to
13210c6
Compare
|
Thanks @jezdez for your review. I've addressed your comments. |
jezdez
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.