Fix 'RemoteYubikeyDevice' object has no attribute 'throttle_reset' #713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a fix and tests for using the remember me feature with any device that doesn't implement
throttle_increase
andthrottle_reset
. This includesRemoteYubikeyDevice
.Motivation and Context
As noted in #699 it is very similar to #397. We should not assume every
Device
implements throttle_increaseand
throttle_reset`How Has This Been Tested?
I don't own a YubiKey, so testing will rely solely on unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: