Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test which checks that fifos outputs are not read #2039

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Add a test which checks that fifos outputs are not read #2039

merged 6 commits into from
Jan 5, 2024

Conversation

manuco
Copy link
Contributor

@manuco manuco commented Dec 29, 2023 •
edited by chrysle
Loading

Requested by @webknjaz, here is a test that currently fail for the issue #2012.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

webknjaz
webknjaz reviewed Dec 29, 2023
View reviewed changes
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Show resolved Hide resolved
@chrysle chrysle added tests Testing and related things skip-changelog Avoid listing in changelog labels Jan 2, 2024
webknjaz
webknjaz reviewed Jan 2, 2024
View reviewed changes
tests/test_cli_compile.py Outdated Show resolved Hide resolved
@manuco manuco closed this Jan 4, 2024
@manuco manuco reopened this Jan 4, 2024
webknjaz
webknjaz approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz added this pull request to the merge queue Jan 5, 2024
Merged via the queue into jazzband:main with commit 41b3c0e Jan 5, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuco @webknjaz @chrysle