Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #550

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Add support for Python 3.12 #550

merged 3 commits into from
Jun 8, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 8, 2023

The Python 3.12 beta is now out, let's start testing it: https://dev.to/hugovk/help-test-python-312-beta-1508/

Because pandas doesn't yet support 3.12, we need to skip the pandas-related tests for now. We can do that with pip install --only-binary :all: pandas, which only installs pandas if there's a prebuilt binary wheel available (as it is for 3.7-3.11), and skip when it's not available.

I didn't add the 3.12 Trove classifier yet. We could wait until full release in October, but some other projects have added it already:

Shall we wait or add it now?

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #550 (5c02f85) into master (f953e06) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   91.40%   91.42%   +0.02%     
==========================================
  Files          28       28              
  Lines        2723     2730       +7     
==========================================
+ Hits         2489     2496       +7     
  Misses        234      234              
Impacted Files Coverage Δ
tests/test_tablib.py 98.74% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion regarding the trove classifier.

@hugovk
Copy link
Member Author

hugovk commented Jun 8, 2023

I've added it then, we don't need to remember to do so later :)

@hugovk hugovk merged commit f5a2937 into jazzband:master Jun 8, 2023
19 checks passed
@hugovk hugovk deleted the test-3.12 branch June 8, 2023 15:43
@hugovk hugovk changed the title Test Python 3.12 beta Add support for Python 3.12 Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants