Fix test frozen time #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are adding new channels as demo data, these channels will have a process_end_date defined to today when the module is installed, and as tests were run with a time frozen in 2023, there were always channels where the process end time was after the scheduled date of the picking. Using relative frozen time should help in keeping the tests successful through different times.
jbaudoux
force-pushed
the
16-release_channel_plan
branch
4 times, most recently
from
05f3333
to
e534373
Compare
jbaudoux
force-pushed
the
16-release_channel_plan
branch
4 times, most recently
from
3bff483
to
107c990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are adding new channels as demo data, these channels will have a process_end_date defined to today when the module is installed, and as tests were run with a time frozen in 2023, there were always channels where the process end time was after the scheduled date of the picking.
Using relative frozen time should help in keeping the tests successful through different times.