-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev twon allocator pointer #103
Conversation
This could use tests. Something like https://www.boost.org/doc/libs/1_83_0/doc/html/interprocess/offset_ptr.html would be idea to demonstrate this works. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 474 474
=========================================
Hits 474 474
☔ View full report in Codecov by Sentry. |
Testing this is non-trivial so I'd defer for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least line 58 T* mem = allocator_traits::allocate(alloc_, 1);
will fail to compile as we still expect a T*
and not a allocator_traits::pointer
.
I'm going to add a branch using Conan to fetch boost so that I can at least test this again |
Does this PR need accompanying wording changes? If so, we need these very soon. |
…value_types into dev-twon-allocator-pointer
I believe the wording in the draft is now updated. Please take a look and make sure you are happy with it. We should get this checked in but this still needs further testing against boost interprocess allocators there are compiler errors to resolve in the test branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Approved with minor tweaks to whitespace.
No description provided.