JAMM-56: Fix access issue to public fields of package private classes #57
Conversation
| "packageProtectedClassPrivateField"); | ||
| } | ||
|
|
||
| public long measure(MemoryMeter meter) { |
There was a problem hiding this comment.
So technically, isn't this again measureDeep? I would call it that probably as otherwise, the test where we compare measure with measureDeep reads a bit weird
| this.privateField = privateField; | ||
| } | ||
|
|
||
| public long measure(MemoryMeter meter) { |
There was a problem hiding this comment.
I think this should be called again measureDeep
| return meter.measure(this) | ||
| + meter.measureDeep(publicField) | ||
| + meter.measureDeep(packageProtectedField) | ||
| + meter.measureDeep(protectedField) | ||
| + meter.measureDeep(privateField) | ||
| + packageProtectedClass.measure(meter); | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks ok to me, just left a small comment about naming.
CI pushed here:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/jamm/41/workflows/87ba096d-3d3f-404e-8d5e-5760ae84ef5e
There was a problem hiding this comment.
Java 11 tests seemed to detect some size changes.
There was a problem hiding this comment.
Thanks for noting, I guess you mean the failing tests? Those were failing even before due to some issues with @contended. More information can be found in the Readme
No description provided.