Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer to ipfs org? #16

Closed
lidel opened this issue May 13, 2020 · 3 comments
Closed

Transfer to ipfs org? #16

lidel opened this issue May 13, 2020 · 3 comments

Comments

@lidel
Copy link
Contributor

lidel commented May 13, 2020 •
edited
Loading

@Stebalien / @jbenet thoughts on moving this package to ipfs org on github?
It is pretty core lib: used by namesys in go-ipfs for DNSLink support, and having it under ipfs org would reduce increase bus factor.
@lidel lidel mentioned this issue May 13, 2020
Closed
@lidel
Copy link
Contributor Author

lidel commented Dec 8, 2020

cc @aschmahmann

@aschmahmann
Copy link

Seems fine by me, although given the status of the linked issue maybe go-ipfs just doesn't need this repo at all?

lidel added a commit to ipfs/kubo that referenced this issue Feb 5, 2021
@lidel
feat: support non-ICANN DNSLink
b383895 
- removes reliance on TLD safelist from jbenet/go-is-domain
  as noted in
  jbenet/go-is-domain#16 (comment)
  jbenet/go-is-domain#19 (review)

- switch DNSLink checks to `net.isDomainName` which only cares about
  name being compliant with RFC 1035, RFC 3696, and is not concerned
  if TLD was blessed by ICANN or some other authority
@lidel lidel mentioned this issue Feb 5, 2021
Closed
1 task
@lidel
Copy link
Contributor Author

lidel commented Feb 5, 2021

I agree, go-ipfs should not care about "legitimacy" of any TLD.
Let's continue in ipfs/kubo#7902

@lidel lidel closed this as completed Feb 5, 2021
@lidel lidel mentioned this issue Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @aschmahmann