Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a little dead code #345

Closed
wants to merge 7 commits into from
Closed

Found a little dead code #345

wants to merge 7 commits into from

Conversation

zebmason
Copy link

@zebmason zebmason commented Mar 8, 2017

Still working on my static analysis tool and looks like it found some dead code that you may wish to remove from the master branch

@jbevain
Copy link
Owner

jbevain commented Mar 17, 2017

Thanks for this contribution! Just like last time, I won't merge the PR as is but I'll look into what it makes sense to pick. Please also do not submit a PR again for code that I voluntarily not touched :)

@jbevain jbevain closed this Mar 17, 2017
@zebmason
Copy link
Author

JB, your welcome. I've successfully removed all the false positives that my tool was reporting on Cecil leaving just Mono.Cecil.Tests.TypeDefinitionRocksTests.Foo.Baz() and 454 members in Microsoft.Cci.Pdb. Obviously didn't want to trouble you with those. Did consider trying to do some class splitting to improve cohesion but wasn't quite brave enough to do so without a better understanding of your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants