Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for key only entry #19

Closed
wants to merge 1 commit into from
Closed

Add test for key only entry #19

wants to merge 1 commit into from

Conversation

koppor
Copy link

@koppor koppor commented Jan 23, 2018

This adds a test case showing that a bibtex entry having a key only raises an exception. IMHO following entry is valid bibtex:

@article{test,
}

The entry just hasn't any fields.

@vruusmann
Copy link
Member

@koppor Are there any other high-priority issues?

@koppor
Copy link
Author

koppor commented Jan 23, 2018

Thank you for asking. It was the only one I encountered while preparing CloudRef for a release.

@koppor koppor deleted the keyonly branch January 23, 2018 18:15
@vruusmann
Copy link
Member

I've pushed JBibTeX version 1.0.17 to the Maven Central repository, which includes this fix.

koppor added a commit to JabRef/cloudref that referenced this pull request Jan 24, 2018
@koppor
Copy link
Author

koppor commented Jan 24, 2018

We successfully released version 0.1.0 of CloudRef: https://github.com/JabRef/cloudref/releases/tag/0.1.0

Thank you for the quick action taken!

@koppor
Copy link
Author

koppor commented Jan 30, 2018

I don't know, why travis builds. Here, the test of parseBibTex() fails, because the entry "first" is not in the list.

@vruusmann
Copy link
Member

The JBibTeX project builds on my computer, and on Travis CI - perhaps there's something wrong with computer/setup.

You could start with a clean checkout. And if that also fails, tell me more about your Architecture/OS/Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants