Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map json conversion #798

Closed
wants to merge 1 commit into from
Closed

Conversation

dylancis
Copy link

@dylancis dylancis commented Jun 28, 2023

JS output jas changed recently and the non-JSON part exlcusion needs to ve revisited.
I tested it and it works.

Pull Request

Before you submit a pull request, please do the following:

  • Add an entry to NEWS concisely describing what you changed.

  • Add unit tests in the tests/testthat directory.

  • Run Build->Check Package in the RStudio IDE, or devtools::check(), to make sure your change did not add any messages, warnings, or errors.

Doing these things will make it easier for the plumber development team to evaluate your pull request. Even so, we may still decide to modify your code or even not merge it at all. Factors that may prevent us from merging the pull request include:

  • breaking backward compatibility
  • adding a feature that we do not consider relevant for plumber
  • is hard to understand
  • is hard to maintain in the future
  • is computationally expensive
  • is not intuitive for people to use

We will try to be responsive and provide feedback in case we decide not to merge your pull request.

Minimal reproducible example

Finally, please include a minimal reprex. The goal of a reprex is to make it as easy as possible for me to recreate your problem so that I can fix it. If you've never heard of a reprex before, start by reading https://github.com/jennybc/reprex#what-is-a-reprex, and follow the advice further down the page. Do NOT include session info unless it's explicitly asked for, or you've used reprex::reprex(..., si = TRUE) to hide it away.

reprex::reprex({
  library(highcharter)
  # insert reprex here

})

Delete these instructions once you have read them.


Brief description of the original problem and the approach behind your solution.

# insert reprex here

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

JS output jas changed recently and the non-JSON part exlcusion needs to ve revisited.
@dylancis dylancis marked this pull request as draft June 28, 2023 16:29
@dylancis dylancis marked this pull request as ready for review July 3, 2023 10:51
@dylancis
Copy link
Author

dylancis commented Jul 3, 2023

not needed anymore #797

@dylancis dylancis closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant