Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HookedSAETransformer #160

Closed
wants to merge 2 commits into from

Conversation

ckkissane
Copy link
Contributor

Description

Moving HookedSAETransformer from TransformerLens to SAELens, which I originally implemented here: TransformerLensOrg/TransformerLens#536

Type of change

Please delete options that are not relevant.

  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] This change requires a documentation update

Checklist:

  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

@jbloomAus
Copy link
Owner

Amazing! Just noting that I'm rebasing a refactor that supports this PR onto this PR so I will accept that PR when finished and close this one. It should show you as the author of those files in the history and do creditation properly.

@jbloomAus
Copy link
Owner

Closing this since it was already merged as part of the 3.0 refactor.

@jbloomAus jbloomAus closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants