Added --bcinfo_csv argument to dms2_bcsubamp
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbloom
requested changes
Nov 17, 2019
There was a problem hiding this comment.
@khdusenbury: I think this line is extraneous:
https://github.com/jbloomlab/dms_tools2/pull/42/files#diff-6ac1788c4919985221cf30a5845dc28cR212
|
Ah yes, looks like I left several test logging lines in there. Will delete and push when I get back to my computer. |
jbloom
previously approved these changes
Nov 18, 2019
jbloom
requested changes
Nov 18, 2019
jbloom
approved these changes
Nov 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added argument
--bcinfo_csvtodms2_bcsubampto allow the barcode info file to be output as a.csvrather than a.txtfile.Added a small test to the
tests/test_bcsubamp.py.Note:
tests/test_batch_bcsubamp.pydoes not test the output of--bcinfoor--bcinfo_csv(and did not previously), so I was not easily able to test the effect of the--bcinfo_csvoption ondms2_batch_bcsubamp, but the changes here are at least compatible with the previous tests.