Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underflow error with YNGKP_M5 #7

Closed
skhilton opened this issue Feb 16, 2017 · 3 comments
Closed

Underflow error with YNGKP_M5 #7

skhilton opened this issue Feb 16, 2017 · 3 comments

Comments

@skhilton
Copy link
Collaborator

skhilton commented Feb 16, 2017

Here are the input files and phydms command I used when I got the underflow error.
NP_phydms_comprehensive.zip

@jbloom
Copy link
Member

jbloom commented Mar 4, 2017

@skhilton: Can you re-attach the files for this bug report? You zipped the symbolic link to the data files rather than the actual files, so I can't run the program on them.

@skhilton
Copy link
Collaborator Author

skhilton commented Mar 4, 2017

@jbloom: Here are the actual files. Also, I have not tried re-running phydms_comprehensive on on this set so I don't know if it still throws an error. Let me know if you want me to do that.
NP_phydms_comprehensive.zip

jbloom added a commit that referenced this issue Mar 4, 2017
@jbloom
Copy link
Member

jbloom commented Mar 4, 2017

Should be resolved by this commit:
7552690

The basic issue is that when there is a distribution model (such as YNGKP M5), underflow actually is OK for any given category at any given site as long as not all categories underflow at a site. The changes fix this.

@skhilton: Can you re-run on your computer and make sure that the error has gone away.

@jbloom jbloom closed this as completed Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants