replace bound on max stringency #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 2.3.5, we let the max stringency parameter go to values greater than 10. But this leads to numerical optimization issues / overflow on real data. So put the bound back at 10; users will have to pre-scale very flat prefs.
|
@skhilton: Sorry, undoing last pull request but we need to make it a newer version as it's not possible to take old versions off PyPI. Can you review this? |
For some reason, one of the tests was seeding initial values out of bounds.
|
I have no idea why previous pull request failed: a test that wasn't even changed starting seeding initial values out of bounds for python 3.7 but not 3.6. This latest commit should fix it! |
|
@skhilton: I think this is now ready to review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.3.5, we let the max stringency parameter
go to values greater than 10. But this leads to
numerical optimization issues / overflow on real
data. So put the bound back at 10; users will
have to pre-scale very flat prefs.