Make it possible to reuse redis connections #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricioabreu
force-pushed
the
reuse-redis-connection
branch
from
de2c692
to
fbaa263
Compare
|
@leandromoreira can you review it please? |
| self.redis = rediscluster.StrictRedisCluster(host=host, port=port, password=password) | ||
|
|
||
| if kwargs.get("redis"): | ||
| self.redis = kwargs["redis"] |
There was a problem hiding this comment.
what happens when this redis is disconnected (due to timeout, lack of healthcheck) or does it "connect" every time it request something?
There was a problem hiding this comment.
Before my commit, this lib connected once and kept a connection with redis (redis attribute of Bullock class).
Imagine that you have lots of locks:
lock_a = Bullock(**config)
lock_b = Bullock(**config)With two locks, there will be two redis connections. My commit lets users reuse redis connections. Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we already have a connection with Redis. Since this library needs Redis settings to connect (host, port, etc) it can be a bit uncomfortable to repeat these parameters.