Set NTLM Negotiate Version field #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always set the NTLM Negotiate version flag and field when generating the message. This aligns the client behaviour to match with SSPI which also sets this value. It should improve compatibility with some NTLM servers which expect the version flag to be set in subsequent token exchanges.
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 31 31
Lines 5387 5387
=======================================
Hits 5385 5385
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set the NTLM Negotiate version flag and field when generating the message. This aligns the client behaviour to match with SSPI which also sets this value. It should improve compatibility with some NTLM servers which expect the version flag to be set in subsequent token exchanges.
Fixes: jborean93/smbprotocol#216