Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up session id lookup issues with ksmbd #224

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix up session id lookup issues with ksmbd #224

merged 1 commit into from
Jun 26, 2023

Conversation

jborean93
Copy link
Owner

The Linux ksmbd module is slightly different in how it returns the session id. This PR fixes up the logic to handle this new workflow as well as simplfiy the existing one.

Fixes: #215

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #224 (a2bfffa) into master (f7eca41) will decrease coverage by 2.38%.
The diff coverage is 100.00%.

❗ Current head a2bfffa differs from pull request most recent head 4182e76. Consider uploading reports for the commit 4182e76 to get more accurate results

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   99.07%   96.70%   -2.38%     
==========================================
  Files          24       24              
  Lines        5081     5034      -47     
==========================================
- Hits         5034     4868     -166     
- Misses         47      166     +119     
Flag Coverage Δ
96.70% <100.00%> (-2.38%) ⬇️
py3.10 ?
py3.11 ?
py3.7 96.70% <100.00%> (-2.34%) ⬇️
py3.8 ?
py3.9 ?
x64 ?
x86 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbprotocol/connection.py 94.15% <100.00%> (-5.70%) ⬇️
src/smbprotocol/session.py 95.20% <100.00%> (+0.02%) ⬆️

... and 13 files with indirect coverage changes

@jborean93 jborean93 force-pushed the session-id branch 2 times, most recently from a2bfffa to ed483f3 Compare June 25, 2023 23:14
@jborean93 jborean93 merged commit deda4d0 into master Jun 26, 2023
@jborean93 jborean93 deleted the session-id branch June 26, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 1 when trying to connect to share hosted by ksmbd
1 participant