Fix DFS recurision for missing files #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that handles a missing path does not currently record existing DFS target servers that have been tried resulting in a recursion error. By ensuring a DFS target is only retried if it hasn't already it should avoid this recursion problem. Fixes: #228
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 99.07% 99.05% -0.02%
==========================================
Files 24 24
Lines 5088 5093 +5
==========================================
+ Hits 5041 5045 +4
- Misses 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that handles a missing path does not currently record existing DFS target servers that have been tried resulting in a recursion error. By ensuring a DFS target is only retried if it hasn't already it should avoid this recursion problem.
Fixes: #228