Add smb_info to a scandir result #251
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 99.05% 99.06%
=======================================
Files 24 24
Lines 5097 5112 +15
=======================================
+ Hits 5049 5064 +15
Misses 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adds the property smb_info to the scandir enumerated result which contains the already retrieved metadata on the file during the scan operation. This provides a more efficient way for callers to retrieve information like the file times, sizes, attributes straight away without having to call .stat() which results in another SMB request to the server.
jborean93
force-pushed
the
scandir-info
branch
from
ddb7a4e
to
1d3c6b5
Compare
|
Thank you so much! I was hoping you'd be fine with using the data and wanted to ask to create a PR for that, but you have been blazing fast! I tested your PR code, it is working smoothly! And even faster on large files than |
You just picked the right time to open the issue, I've been neglecting this library for a while now and needed to get back to it.
Thanks for testing, I'm actually surprised it's faster than a cifs mount but always happen to see that there are some benefits here :) |
Adds the property smb_info to the scandir enumerated result which contains the already retrieved metadata on the file during the scan operation. This provides a more efficient way for callers to retrieve information like the file times, sizes, attributes straight away without having to call .stat() which results in another SMB request to the server.
Fixes: #250