Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish cleanup tasks for issue #18 #77

Closed
bfitzpat opened this issue Jan 7, 2019 · 2 comments
Closed

Finish cleanup tasks for issue #18 #77

bfitzpat opened this issue Jan 7, 2019 · 2 comments
Assignees
@bfitzpat
Labels
task
Milestone
0.9.0

Comments

@bfitzpat
Copy link
Contributor

bfitzpat commented Jan 7, 2019

The PR for issue #18 (camel-tooling/generator-camel-project#38) was automatically merged after a successful PR build, which left a few bits of feedback stranded.

  • There is an indentation issue in tests/spring/src/test/java/org/jboss/fuse/wsdl2rest/test/calculator/CalculatorDocLitTest.java in the searchForValue method (around line 138-140)
  • In the same method, @apupier suggested - "what about using try-with-resource notation, it will avoid the finally block to close the scanner"
@bfitzpat bfitzpat mentioned this issue Jan 7, 2019
Merged
bfitzpat added a commit to bfitzpat/wsdl2rest that referenced this issue Jan 8, 2019
@bfitzpat
issue jboss-fuse#77 - finish cleanup tasks
cc7d7d3 
-- fixed indent issues with CalculatorDocLitTest searchForValue
-- fixed searchForValue to use try-with-resource notation

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>
@bfitzpat
Copy link
Contributor Author

bfitzpat commented Jan 8, 2019

Created PR #79

@bfitzpat bfitzpat self-assigned this Jan 8, 2019
@tdiesler tdiesler added the task label Jan 30, 2019
@tdiesler tdiesler added this to the 0.9.0 milestone Jan 30, 2019
bfitzpat added a commit that referenced this issue Sep 25, 2019
@bfitzpat
issue #77 - finish cleanup tasks (#79)
08d43de 
-- fixed indent issues with CalculatorDocLitTest searchForValue
-- fixed searchForValue to use try-with-resource notation

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>
bfitzpat added a commit to bfitzpat/wsdl2rest that referenced this issue Sep 25, 2019
@bfitzpat
issue jboss-fuse#77 - finish cleanup tasks (jboss-fuse#79)
dce61de 
-- fixed indent issues with CalculatorDocLitTest searchForValue
-- fixed searchForValue to use try-with-resource notation

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>
(cherry picked from commit 08d43de)
cunningt added a commit that referenced this issue Sep 25, 2019
@cunningt
Merge pull request #92 from bfitzpat/0.8.x.redhat-7-x
1a9b46f 
issue #77 - finish cleanup tasks (#79)
@bfitzpat
Copy link
Contributor Author

Resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfitzpat bfitzpat

Labels
task
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@tdiesler @bfitzpat