[#51] Provide a default Jakarta EE 10 application to build #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use https://github.com/jboss-eap-up-and-running/eap8-getting-started as the default Jakarta EE application This fixes jbossas#51 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
github-actions
bot
added
documentation
mchoma
reviewed
Jun 16, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| A Helm chart for building and deploying a [JBoss EAP 8](https://www.redhat.com/en/technologies/jboss-middleware/application-platform) application on OpenShift. | |||
|
|
|||
| ## The Helm Chart for EAP 8 Beta is a Technology Preview feature only. | |||
| ## The Helm Chart for EAP 8 is a Technology Preview feature only. | |||
There was a problem hiding this comment.
Technology Preview
I thought it is not Technology Preview anymore for EAP8
mchoma
reviewed
Jun 16, 2023
| @@ -149,7 +149,7 @@ If the application image has been built by another mechanism, you can skip the b | |||
| | `build.sourceSecret`|Name of the secret containing the credentials to login to Git source reposiory | - | The secret must exist in the same namespace or the chart will fail to install - [OKD documentation](https://docs.okd.io/latest/cicd/builds/creating-build-inputs.html#builds-manually-add-source-clone-secrets_creating-build-inputs) | | |||
| | `build.triggers.genericSecret`| Name of the secret containing the WebHookSecretKey for the Generic Webhook | - | The secret must exist in the same namespace or the chart will fail to install - [OKD documentation](https://docs.okd.io/latest/cicd/builds/triggering-builds-build-hooks.html) | | |||
| | `build.triggers.githubSecret`| Name of the secret containing the WebHookSecretKey for the GitHub Webhook | - | The secret must exist in the same namespace or the chart will fail to install - [OKD documentation](https://docs.okd.io/latest/cicd/builds/triggering-builds-build-hooks.html) | | |||
| | `build.uri` | Git URI that references your git repo | <required> | Be sure to specify this to build the application. | | |||
| | `build.uri` | (**required**) Git URI that references your Git repository | https://github.com/jboss-eap-up-and-running/eap8-getting-started | Be sure to specify this to build your own application. | | |||
There was a problem hiding this comment.
Is it correct to call it required when default is provided when omitted?
There was a problem hiding this comment.
It is required from a schema perspective (
eap-charts/charts/eap8/values.schema.json
Line 34 in 51c29cb
The default value in values.yaml installs an example provided by us. In practice, an user must change that uri to point to their Git repo if they want to deploy their application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #51