JBIDE-20152 scripts for tagging via buildinfo #132
Conversation
|
+0.5 for buildinfo_to_tags.py -- you need to document usage to include the mention of curl on lines 12-14 and line 24.
After that, +1. Did not review util/checktags.py, but I assume you tested it because you found missing comma on line 47/59. |
|
Was in a hurry so I missed that I included my updates to checktags.py in this PR. I think I'll split those out. I have a hard time following your comments that just list line numbers and I can't really see why/what in those lines you mean curl should be mentioned ? Could you put the comments on the lines so I can get a better idea what you refer to ? And yes, I'll go and add usage text to these. |
|
Updated the branch. checktags.py was unrelated to this thus moved to separate PR #133 tagrepos.py was missing from this PR, that is now fixed so you can actually run the commands. readme.adoc updated with description of the new scripts. |
| # moar output, set = 1 | ||
| debug=0 | ||
|
|
||
| usage = "Usage: %prog [-n NAME] \n\n\ |
There was a problem hiding this comment.
you need to document usage to include the mention of curl on lines 12-14 and line 24.
There was a problem hiding this comment.
not sure why you want curl. why not cat or anything else ?
I'll update it to explicitly state it needs its input on standard input.
| except GithubException as ge: | ||
| if ge.status == 422: | ||
| results = str(ge) | ||
| elif ge.status == 400: |
There was a problem hiding this comment.
Since both ifs now do the same thing, could the y be combined into a single line?
if ge.status == 400 or ge.status == 422:
results = str(ge)
There was a problem hiding this comment.
yes, but that is just going to make it harder to edit/debug. But i've changed it since not major deal.
tagrepos.py - take csv input and perform tagging via github API
buildinfototags.py - take buildinfo.json and convert to csv format understood
by tagrepos.py
Seperate python utilities to convert buildinfo.json to csv and then one for making the tags.