Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-19635 - Invisible checkboxes in Software/Update pane in central #333

Closed
wants to merge 1 commit into from

Conversation

snjeza
Copy link
Member

@snjeza snjeza commented Apr 20, 2015

https://issues.jboss.org/browse/JBIDE-19635
Invisible checkboxes in Software/Update pane in central

@fbricon
Copy link
Member

fbricon commented Apr 20, 2015

Nice catch Snjeza.
But please don't use the Plugin activator for this. Use a dedicated class

IEclipseContext context = application.getContext();
IThemeEngine engine = context.get(IThemeEngine.class);
ITheme theme = engine.getActiveTheme();
if (theme != null && engine instanceof ThemeEngine) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine instanceof ThemeEngine is enough to check for non-null values

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the PR.

@fbricon
Copy link
Member

fbricon commented May 15, 2015

Applied in master

@fbricon fbricon closed this May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants