Rewrite initial_recombination.py in pure python #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzanka
reviewed
Aug 16, 2022
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
…com/jbrage/IonTracks into feature/28-initial-recombination-py
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 17, 2022
grzanka
reviewed
Aug 18, 2022
hadrons/initial_recombination.py
Outdated
| # update the positive and negative arrays | ||
| start_time = time.time() | ||
|
|
||
| positive_array[1:(no_x-1),1:(no_x-1),1:(no_z_with_buffer-1)] = positive_array_temp[1:(no_x-1),1:(no_x-1),1:(no_z_with_buffer-1)] |
There was a problem hiding this comment.
Suggested change
| positive_array[1:(no_x-1),1:(no_x-1),1:(no_z_with_buffer-1)] = positive_array_temp[1:(no_x-1),1:(no_x-1),1:(no_z_with_buffer-1)] | |
| positive_array[1:-1,1:-1,1:-1] = positive_array_temp[1:-1,1:-1,1:-1] |
what about such code ?
There was a problem hiding this comment.
Yeah, that should be better. I didn't really look into what no_x etc. were.
|
@retkiewi fix failing tests |
|
Hmm, they were passing on my end, probably some compilation weirdness/me forgetting to add a file before committing. |
|
Never mind, I didn't notice I was selecting only one of the tests to be run locally. Should be working now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28