updated mqr gbm parallel options #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
included options for parallel over quantiles. Unfortunately more duplicated code... updated example updated docs
jbrowell
approved these changes
Jan 31, 2020
|
Yes - repeated code is not going to be sustainable... perhaps we should be writing sub-functions are nested in the parallel chunks? |
|
Definitely, think this would require the "quantile" for loop to be embedded in the parallel function at the moment, which will take a bit of re-organizing. I will merge this for now and put this as an issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included options for parallel over quantiles :) Unfortunately more duplicated similar code...will have a think about that
updated example
updated docs
#15 (comment)