Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode dirname/filename extended header #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoheie
Copy link
Contributor

@yoheie yoheie commented Oct 24, 2015

解凍時のUnicode (UTF-16LE)ファイル・ディレクトリ名の拡張ヘッダーへの対応を追加しました。
configureオプションに--enable-unicode-filename (デフォルト yes)を追加しています。

このまま取り込んでもらうには 2点ほど懸念事項があります。

  • ディレクトリ名の区切りの変換について 0xFF・0xFF → 0x2F・0x00 (U+002F '/') の固定としていますが問題ないでしょうか?
  • 現状はiconv版のコードのみとなっています。Mac OS用の変換コードも用意すべきでしょうか?

@yoheie yoheie force-pushed the support-unicode-name branch 2 times, most recently from d0d2ee4 to 7965cf6 Compare November 30, 2015 13:42
@yoheie yoheie force-pushed the support-unicode-name branch 2 times, most recently from 7eaabdb to d7333de Compare January 25, 2016 00:09
@yoheie yoheie force-pushed the support-unicode-name branch 2 times, most recently from 6c4e5c7 to 9e6d7c2 Compare May 8, 2016 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant