Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Implicit buffers not detected #49

Closed
ccleaud opened this issue Dec 29, 2015 · 1 comment
Closed

Implicit buffers not detected #49

ccleaud opened this issue Dec 29, 2015 · 1 comment

Comments

@ccleaud
Copy link

ccleaud commented Dec 29, 2015

Hi,

Implicit buffers are not yet detected thus not listed in the 3P code explorer under "Tables used" section.
Consider following code: nothing is detected (often needed to press the refresh button).

DEFINE TEMP-TABLE tt_batch_compile_files NO-UNDO XML-NODE-NAME "file"
    FIELD cSourceFullFileName   AS CHARACTER    XML-NODE-NAME "file-name"
    FIELD cErrorsDir            AS CHARACTER    XML-NODE-NAME "error-dir"
    FIELD cXmlXrefFile          AS CHARACTER    XML-NODE-NAME "xref-file"
    FIELD cListingFile          AS CHARACTER    XML-NODE-NAME "listing-file"
    INDEX idx_pk IS PRIMARY UNIQUE.

DEFINE TEMP-TABLE tt_batch_compile_settings NO-UNDO XML-NODE-NAME "setting"
    FIELD cKey        AS CHARACTER    XML-NODE-NAME "key"
    FIELD cValue      AS CHARACTER    XML-NODE-NAME "value"
    INDEX idx_pk IS PRIMARY UNIQUE cKey.


DEFINE DATASET dsBatchCompile XML-NODE-NAME "batch-compile"
    FOR tt_batch_compile_files, tt_batch_compile_settings.

Just adding this line changes all:
DEFINE BUFFER bXXX FOR tt_batch_compile_files.

Can you fix please?

@jcaillon
Copy link
Owner

Hmm, actually the problem is that it shows the table in the code explorer after you add
DEFINE BUFFER bXXX FOR tt_batch_compile_files.
because it shouldn't! At the moment, i intended to only show the TABLES used in the code, not the temp tables.

Anyway; I've added a section temp-tables used after the tables used to differentiates with DATABASE TABLES. The information I'm providing to the user are the following :

  • which tables / temp-tables are used in the program?
  • do i call database tables without using a buffer?
  • do i call a database table without specifying its database?

I'm answering all those questions in the next release; please note that i don't exhaustively list ALL the uses, i only list the places where the temptables/tables are used DIRECTLY (= not through a buffer); i don't list the location where the buffers are used. I really think it would be overdoing it.

jcaillon added a commit that referenced this issue Jan 1, 2016
- #50: Assume default PROPATH for include files is the current source directory
- #54: wait the minimum number of char required even after a ":"
- #49: major improvement of tables/temp-tables usage detection; the code explorer now allows you to answers those questions:
 * which tables / temp-tables are used in the program?
 * do i call database tables without using a buffer?
 * do i call a database table without specifying its database?
- #24: reduced loading time to a flat amount
- New option to automatically hide the code/file explorer when switching to non progress document
- Complete revamp of the "Options" menu

**Corrected issues :**

- #56: now prevents the tooltip from cropping the name of the hovered word
- #58: in strings, only functions trigger the tooltip
- #57: fixed with the last commit
- #48: fixed a bug that would sometime cause a glitch on the text display in scintilla
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants