-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac compiling #69
Mac compiling #69
Conversation
It turns out that test_mult_clients fails on mac for some reason, so I opened an issue ( #105 ). The latest two commits wrap the code for the named semaphore in an |
Managed to compile this after installing gcc 5.4 with ports:
and changing the |
Any problems with this? Looks good to me. |
Latency with TCP is now around ~110us for a small put or get op. In line with the latency I get from |
Resolves #54 . Set up cirrus so that it compiles on MacOS. I set this up as a pull request into the TCP branch so that it's easier to see what I changed, as this is based off the TCP branch. I reckon if we want to merge right into master we could just do that after we merge TCP.
Compiles on both Linux and Mac, and make check passes. cpplint has no errors.
Edit: Make check actually fails on linux. I'll look into this.
Make benchmark currently does not work due to the setup of
run_benchmarks.py
, but this is fixed in the main TCP branch.Changes
error.h
header file from Synchronization.h as it was unused, and is not present on MacsTime.h
toCirrusTime.h
. G++ was using ourTime.h
instead of the systemtime.h
, leading to issues with compilation.bootstrap.sh
that automatically rename the dynamic version of libcityhash so that it cannot be found by the linker. Does so in a platform dependent manner.