Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis tests sometimes don't pass due to travis slowness #71

Closed
jcarreira opened this issue Jul 28, 2018 · 5 comments
Closed

Travis tests sometimes don't pass due to travis slowness #71

jcarreira opened this issue Jul 28, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jcarreira
Copy link
Owner

It seems sometimes the travis tests fail because not enough time is given for the test to converge.

Should we increase the threshold? @andrewmzhang @yangryan0

@jcarreira jcarreira added the bug Something isn't working label Jul 28, 2018
@andrewmzhang
Copy link
Collaborator

I think that's a good quick fix.

To fix it more completely maybe we should sum up the total number of updates and compare that to the loss. Although this would require investigating some sort of updates to loss relationships.

@jcarreira
Copy link
Owner Author

That's too complex. I suggest we relax the threshold.

@yangryan0
Copy link
Collaborator

yangryan0 commented Jul 31, 2018 via email

@jcarreira
Copy link
Owner Author

Ok, that sounds good to me.

@jcarreira
Copy link
Owner Author

Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants