Travis testing #49
Merged
Travis testing #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarreira
reviewed
Jul 6, 2018
| model_lock.lock(); | ||
| auto avg_loss = check_error(model.get(), dataset); | ||
| model_lock.unlock(); | ||
| if (avg_loss <= 0.15) { |
There was a problem hiding this comment.
This value doesn't seem correct. Will check later.
jcarreira
requested changes
Jul 6, 2018
| @@ -0,0 +1,88 @@ | |||
| #include <unistd.h> | |||
There was a problem hiding this comment.
This file should be in the tests folder (and the binary too)
|
We have a cirrus/tests folder for tests. Why don't we put the tests code there? |
jcarreira
approved these changes
Jul 8, 2018
andrewmzhang
pushed a commit
to andrewmzhang/cirrus-1
that referenced
this pull request
Oct 27, 2018
Travis testing
andrewmzhang
pushed a commit
to andrewmzhang/cirrus-1
that referenced
this pull request
Oct 27, 2018
Travis testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.