Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FilteredAdapter interface. #25

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Support FilteredAdapter interface. #25

merged 1 commit into from
Jan 27, 2021

Conversation

shy1st
Copy link
Contributor

@shy1st shy1st commented Jan 26, 2021

Fix: #24

@coveralls
Copy link

coveralls commented Jan 26, 2021

Pull Request Test Coverage Report for Build 90

  • 187 of 216 (86.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 85.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/org/casbin/adapter/JDBCAdapter.java 30 35 85.71%
src/main/java/org/casbin/adapter/JDBCBaseAdapter.java 157 181 86.74%
Totals Coverage Status
Change from base Build 84: 2.6%
Covered Lines: 225
Relevant Lines: 264

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
src/main/java/org/casbin/adapter/JDBCBaseAdapter.java Outdated Show resolved Hide resolved
src/test/java/org/casbin/adapter/AdapterCreator.java Outdated Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Jan 27, 2021

@shy1st see how I wrote the code for jCasbin: https://github.com/casbin/jcasbin/tree/master/src/main/java/org/casbin/jcasbin/main

We have defined 6 Enforcer classes to separate the code into multiple files. But they provide the single Enforcer class to the end user.

image

@hsluoyz
Copy link
Member

hsluoyz commented Jan 27, 2021

@shreyasGit plz review.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 27, 2021

lgtm

@hsluoyz hsluoyz merged commit fc6523c into jcasbin:master Jan 27, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Jan 27, 2021

@shy1st PR merged, plz make a new release on Maven & GitHub Releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FilteredAdapter interface
3 participants