Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an unresolved APNs hostname to improve GOAWAY handling #571

Merged

Conversation

aleksandr-lapushkin
Copy link

As discussed in: Connection Refused to APNs

As a small update to the discussion: I did some extra debugging and was able to verify that upon re-establishing the connection to APNs after a GOAWAY is received the IP remains the same. This PR aims to fix that issue.

I was also able to verify that with the fix in place, the IP indeed does change after we reconnect following a GOAWAY.

@jmason
Copy link

jmason commented Jan 3, 2018

makes sense to me, 👍

Copy link
Owner

@jchambers jchambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aleksandr-lapushkin
Copy link
Author

Just as an update: we've been using our fork with this change for at least a week now in production. No connection errors of the kind that we observed earlier have appeared during this timeframe. Thus I'd say this was just what we needed.
Also, @jchambers, I'm guessing this will get merged by someone other than myself (for obvious reasons)?

@jchambers
Copy link
Owner

Also, @jchambers, I'm guessing this will get merged by someone other than myself (for obvious reasons)?

Yes. Putting out a new release is on my to-do list, but I still need to resolve some other (non-Pushy) priorities first.

@aleksandr-lapushkin
Copy link
Author

Got it. thanks.

@jchambers jchambers added this to the v0.12 milestone Jan 13, 2018
@jchambers jchambers merged commit 743ceab into jchambers:master Jan 13, 2018
@jchambers
Copy link
Owner

@aleksandr-lapushkin we just released Pushy 0.12, which includes this fix. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants