Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update page automatically when the cookies are ready #5

Closed
jchayan opened this issue Sep 12, 2020 · 1 comment
Closed

Feature: Update page automatically when the cookies are ready #5

jchayan opened this issue Sep 12, 2020 · 1 comment
Assignees
@jchayan
Labels
enhancement New feature or request

Comments

@jchayan
Copy link
Owner

jchayan commented Sep 12, 2020

Given I have unfinished cookies in an oven
And I am on the oven page
Then I should see that the cookies are not yet ready
When the cookies finish cooking
Then I should see that the cookies are ready
Note: Periodic polling is acceptable, but only the relevant part of the page should update
jchayan added a commit that referenced this issue Sep 12, 2020
@jchayan
Updates oven page automatically when cookie is ready
63c9fe2 
- Puts cookie retrieval markup in separate partial
- Adds SSE support on ovens controller
- Adds SSE listener on the client side

Issue: #5
@jchayan jchayan mentioned this issue Sep 12, 2020
Merged
@jchayan jchayan self-assigned this Sep 12, 2020
@jchayan jchayan added the enhancement New feature or request label Sep 12, 2020
@jchayan jchayan closed this as completed Sep 12, 2020
@jchayan jchayan reopened this Sep 12, 2020
@jchayan
Copy link
Owner Author

jchayan commented Sep 12, 2020

Important observation here. I lost a lot of time trying to figure out why RSpec stops working when ActionController::Live is composed into a Rails Controller. I would appreciate any help since I wasn't able to figure it out.

I know it's related to ActionController::Live because I added a signal trap to the RSpec process in order to get the backtrace (as suggested here)

I didn't continue to avoid losing more time

jchayan added a commit that referenced this issue Sep 12, 2020
@jchayan
Fixes corrections:
57b9fb1 
- Fixes users being able to query other users ovens
- Fixes hardcoded oven_id in EventSource constructor argument
- Tiny refactor in user oven lookup

Issue: #5
jchayan added a commit that referenced this issue Sep 12, 2020
@jchayan
Fixes corrections:
50007d4 
- Fixes users being able to query other users ovens
- Fixes hardcoded oven_id in EventSource constructor argument
- Fixes double subscription to event source (check comments)
- Tiny refactor in user oven lookup

Issue: #5
@jchayan jchayan mentioned this issue Sep 12, 2020
Merged
jchayan added a commit that referenced this issue Sep 12, 2020
@jchayan
Merge pull request #10 from jchayan/issue-5
8bf6e33 
Fixes corrections noted in #5
@jchayan jchayan closed this as completed Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchayan jchayan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchayan