Fix bug related to once animations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do not set `self.current_frame = 0;` when a `Once` animation has finished, then the animation is never able to be executed again. With this update, the animation is able to be properly restarted next time the `Play` component is added to the corresponding entity.
|
Good catch, thanks :-) Do you mind adding a test for this case? Otherwise don't worry I'll add it myself ;-) |
jcornaz
force-pushed
the
bug-with-once-animations
branch
from
3751beb
to
6d6a229
Compare
|
@jcornaz thanks boss! Thanks for the great work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not set
self.current_frame = 0;when aOnceanimation has finished, then the animation is never able to be executed again.With this update, the animation is able to be properly restarted next time the
Playcomponent is added to the corresponding entity.