Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1.0.0 release #8

Merged
merged 30 commits into from
Jan 1, 2023
Merged

Feature/1.0.0 release #8

merged 30 commits into from
Jan 1, 2023

Conversation

jcouture
Copy link
Owner

@jcouture jcouture commented Mar 26, 2022

A recent pull request left me uneasy because the project was missing unit testing altogether. So, low and behold unit tests!

Here’s a summary of what’s new for the big 1-0 release:

  • Unit tests;
  • Simplify the FileHelper class to avoid having multiple methods doing the same thing;
  • Avoid using camelCase when naming variables;
  • Convert parts of the code to a more modern Ruby syntax (no more hash rocket);
  • Present the project’s new fresh logo!

Copy link
Contributor

@lodonoughue lodonoughue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

Important parts are well tested.
I love the part about npm6 and  npm7.

One thing you could do is add tests for the commit/tag logic.

@jcouture
Copy link
Owner Author

jcouture commented Apr 8, 2022

@lodonoughue Thanks for the much appreciated feedback.

Good thinking, I’m looking for a good and efficient way to add test coverage for the Repository service as well as the commit and tag logic.

Stay tuned! 😏

@jcouture jcouture merged commit d5e7550 into main Jan 1, 2023
@jcouture jcouture deleted the feature/1.0.0-release branch January 1, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants