Call __eq__ from __ne__ for user defined __eq__
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user manually defines an `__eq__` for a `Struct` class, the default `__ne__` implementation will now call the user-defined `__eq__` and invert the result, rather than applying the standard `__ne__` logic. This makes it easier for users to manually override `__eq__`, and matches the behavior of standard python classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user manually defines an
__eq__for aStructclass, the default__ne__implementation will now call the user-defined__eq__and invert the result, rather than applying the standard__ne__logic. This makes it easier for users to manually override__eq__, and matches the behavior of standard python classes.Fixes #585.