-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SCC expansion #118
Conversation
|
||
|
||
def expand_source_SCCs( | ||
sd: SuccessionDiagram, | ||
expander: ExpanderFunctionType = expand_bfs, | ||
check_maa: bool = True, | ||
check_maa: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason check_maa
isn't optional anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I forgot to put it back. I was playing with it when I started using the function recursively because it seemed like the flag wasn't propagating correctly. I'll put it back.
f" > [{node_id}] Found {len(source_scc_diagrams)} sub-diagrams while expanding node." | ||
) | ||
|
||
# If there are no source SCCs, this node is a fixed-point and we can save it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would having no source SCCs make the node a fixed point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proof-read the code to my best ability. Everything looks very nice.
Should fix the SCC expansion bug, plus perform some other clean up in that Python module.