Sudoku #2PR Changed button order #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 27, 2018 15:59
This improves the clarity of the code Small Bug fixes Class is now completely working. Added Disclaimer and some general informations.
1. An unused variable has been removed. 2. The return type of a method is specified.
- Issue: The possible values are shown red instead of black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, I have changed the order of the buttons on the left side of the GUI.
At the top are now the buttons to open a new standard puzzle and to load your own puzzle. Below that are all the other buttons. As long as you are in the enter mode the upper buttons are activated and the lower ones deactivated. As soon as you enter the solve mode, the upper two buttons are deactivated and the lower buttons are activated.
I made that change for the normal, killer and 16 * 16 sudokus.
During this step, I separated the code for the different sudokus into own classes. I noticed several new mistakes. For example 16 * 16 Sudokus will not fill all fields with suggestions.
Old button order:
New button order:
