Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When REAPER's jump dialog closes, can OSARA report the new edit cursor position? #1041

Closed
ScottChesworth opened this issue Apr 2, 2024 · 4 comments · Fixed by #1045
Closed
Labels
enhancement p2 Medium priority.

Comments

@ScottChesworth
Copy link
Collaborator

If possible, it would be excellent to hear the new edit cursor position as validation. At the moment we hear REAPER's title bar being reported, which confirms that the dialog has been closed, but doesn't confirm where the user has jumped to.

@ScottChesworth ScottChesworth added enhancement p2 Medium priority. labels Apr 2, 2024
@jcsteh
Copy link
Owner

jcsteh commented Apr 4, 2024

The open question is whether that action blocks until the dialog closes or whether it just opens the dialog and returns. I suspect the former based on the fact that the parent window gets disabled. However, if it's the latter, that will be much harder and probably Windows specific.

@jcsteh
Copy link
Owner

jcsteh commented Apr 4, 2024

Also, what do we do if the cursor doesn't move; e.g. if the user pressed escape or (don't know why anyone would do this, but...) pressed enter without changing the value?

@ScottChesworth
Copy link
Collaborator Author

if it's the latter, that will be much harder and probably Windows specific.

How would you recommend I investigate the difference?
I reckon suppressing the title bar would be fine as a Windows specific hack in this case, there's not a splurge of title bar on Mac when the jump dialog closes.

@ScottChesworth
Copy link
Collaborator Author

what do we do if the cursor doesn't move;

Run OSARA: Report edit/play cursor position and transport state whenever the dialog is dismissed? That breaks our usual convention of if we don't move then we don't speak, but arguably I reckon it's still more useful feedback than what we get right now, and like... is anyone gonna know? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement p2 Medium priority.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants