-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSARA incorrectly reports ticks if the time signature denominator isn't 4 #1084
Comments
As a side note, strictly speaking, we're using the term "beats" incorrectly with respect to 6/8. In 6/8, there are two beats per bar, with a beat being a dotted quarter note. The 6 eighth notes per measure are called pulses. But I think REAPER also gets this wrong and goes a step further in that BPM seems to actually be quarter notes per minute, rather than beats per minute. I think most other DAWs have a similarly incorrect definition. Gotta love the fact that DAWs don't follow music theory. |
…gnature denominator is something other than 4; e.g. 6/8. Previously, for example, if the time signature was 6/8, we would incorrectly report a 16th note as 480 ticks instead of 240 ticks. To fix this, correctly take the time signature denominator into account when using MIDI PPQ (which is per quarter note, not per beat). Fixes #1084.
…gnature denominator is something other than 4; e.g. 6/8. (issue #1084, PR #1093) Previously, for example, if the time signature was 6/8, we would incorrectly report a 16th note as 480 ticks instead of 240 ticks. To fix this, correctly take the time signature denominator into account when using MIDI PPQ (which is per quarter note, not per beat).
This confused the hell out of me until I figured out what was going on.
STR:
I think the problem is that we assume that ppq is ticks per beat, but it's actually ticks per quarter. We need to take the time signature denominator into account. TimeMap2_timeToBeats does provide this info; we just don't use it. We'll probably need to pass this into various time reporting functions.
The text was updated successfully, but these errors were encountered: