Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing time reporting when moving by both min/sec and measures/beats #31

Closed
jcsteh opened this issue Apr 2, 2015 · 2 comments
Closed
Labels

Comments

@jcsteh
Copy link
Owner

jcsteh commented Apr 2, 2015

(Originally reported by @GianlucaApollaro on a call.)

Str:

  1. Open a project which is at least 1 minute long.
  2. Set the time ruler unit to minutes:seconds.
  3. Go to end.
  4. Go back several measures (so it crosses the minute boundary). Do not use any other time commands while doing this.
  5. Go to end.
  • Expected: Minutes and seconds should be reported.
  • Actual: Only seconds are reported.

This occurs because the measure/beat and min/sec times are cached separately and only the one that is reported is updated. If the time unit is min/sec, we should always update the cached min/sec as well when moving by measure/beat.

@jcsteh jcsteh added the bug label Apr 2, 2015
@jcsteh
Copy link
Owner Author

jcsteh commented Apr 2, 2015

On further reflection, I'm not sure this solution is ideal. Say the user is at 5 minutes and moves back by measure until they get to 3 minutes (but obviously measures will be reported). If they then hit left arrow, "59 seconds" will be reported instead of "2 minutes 59 seconds". However, the user didn't know they were at 3 minutes, so that might be really confusing.

At this point, my thinking is that I should just forget the cached times whenever a different unit is reported. For example, if you're moving with the arrow keys and they're reporting min/sec, as soon as you move by measure, the next press of the arrows would read the full min/sec time, even if you hadn't moved to a new minute. That might be slightly more verbose in some cases, but it's also more reliable.

Thoughts @GianlucaApollaro @ScottChesworth?

@chrisbelle2015
Copy link

Accuracy and correct info always win out over verbose, you can always
shut up the speech.

On 4/2/2015 6:32 AM, jcsteh wrote:

On further reflection, I'm not sure this solution is ideal. Say the
user is at 5 minutes and moves back by measure until they get to 3
minutes (but obviously measures will be reported). If they then hit
left arrow, "59 seconds" will be reported instead of "2 minutes 59
seconds". However, the user didn't know they were at 3 minutes, so
that might be really confusing.

At this point, my thinking is that I should just forget the cached
times whenever a different unit is reported. For example, if you're
moving with the arrow keys and they're reporting min/sec, as soon as
you move by measure, the next press of the arrows would read the full
min/sec time, even if you hadn't moved to a new minute. That might be
slightly more verbose in some cases, but it's also more reliable.

Thoughts @GianlucaApollaro https://github.com/GianlucaApollaro
@ScottChesworth https://github.com/ScottChesworth?


Reply to this email directly or view it on GitHub
#31 (comment).

@jcsteh jcsteh changed the title Cached min:sec time should udpate when moving by measures/beats Confusing time reporting when moving by both min/sec and measures/beats Apr 2, 2015
@jcsteh jcsteh closed this as completed in 7fe929b Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants