Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal paused after exception is thrown in async function #546

Closed
jcubic opened this issue Dec 12, 2019 · 0 comments
Closed

Terminal paused after exception is thrown in async function #546

jcubic opened this issue Dec 12, 2019 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 12, 2019

Expected behavior

I should see error message when command fail to execute

Actual behavior

if async comamnd like (img) throw exception in fetch and don't show anything and (the terminal is paused)

Steps to reproduce

img https://www.fillmurray.com/460/300

it don't have CORS headers, so fetch will fail and async function will throw exception (that will be converted behind the scenes to promise fail) and it's ignored, then is never called so terminal is still paused.

@jcubic jcubic added the Bug label Dec 12, 2019
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 15, 2019
@jcubic jcubic closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant