Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines don't show up in prompt #734

Closed
jcubic opened this issue Jan 11, 2022 · 1 comment
Closed

Empty lines don't show up in prompt #734

jcubic opened this issue Jan 11, 2022 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jan 11, 2022

Issue summary

Empty lines are ignored by typing animation

Expected behavior

Text print properly new lines

Actual behavior

Text jumps

Steps to reproduce

  1. Open Gaiman Demo
  2. Enter: echo* (get "/gaiman.txt"), 5
@jcubic jcubic added the Bug label Jan 11, 2022
@jcubic
Copy link
Owner Author

jcubic commented Jan 11, 2022

The problem is that the prompt can't contain an empty line:

The fix is to use:

.cmd .cmd-line::before {
    content: "\0200B";
    display: inline-block;
    width: 0;
}

The same as with .terminal-output div but without float: left

@jcubic jcubic changed the title Typing animation jumps on empty lines Empty lines don't show up in prompt Jan 11, 2022
jcubic added a commit that referenced this issue Jan 29, 2022
The issue found while using typig animation of ASCII art
When using Gaiman playgroud
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jan 29, 2022
jcubic added a commit that referenced this issue Feb 9, 2022
The issue found while using typig animation of ASCII art
When using Gaiman playgroud
@jcubic jcubic closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant