Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email in echo prompt is displayed as link #768

Closed
jcubic opened this issue Mar 26, 2022 · 1 comment
Closed

Email in echo prompt is displayed as link #768

jcubic opened this issue Mar 26, 2022 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone
2.33.0

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 26, 2022

Issue summary

This was never happening. So this is a bug. emails like strings (especially those from prompt) should not be printed as links.

Expected behavior

emails like strings are just text

Actual behavior

Emails are links

Steps to reproduce

  1. Open Fake Linux Terminal
  2. Type enter

Browser and OS

NA
@jcubic jcubic added the Bug label Mar 26, 2022
@jcubic jcubic added this to the 2.33.0 milestone Mar 26, 2022
jcubic added a commit that referenced this issue Mar 27, 2022
@jcubic
disable links in echo command #768
47a15d3
@jcubic jcubic added resolved if issue is resolved, it will be open until merge with master and removed resolved if issue is resolved, it will be open until merge with master labels Mar 27, 2022
@jcubic
Copy link
Owner Author

jcubic commented Mar 28, 2022

There is still an issue when using typing animation.

jcubic added a commit that referenced this issue May 3, 2022
@jcubic
fix showing link for email like prompt #768
72f82ce
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 3, 2022
jcubic added a commit that referenced this issue May 3, 2022
@jcubic
fix lint error #772, #768
08819a8
@jcubic jcubic closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.33.0
Development

No branches or pull requests
1 participant
@jcubic