Unmounting Error When Output Limit Exceeds View

[MrPurpleProgrammer]

Issue summary

This function in /node_modules/jquery.terminal/js/jquery.terminal.js at Line 7341 has a minor bug regarding the variable "lines".
This variable is an object, but the index is being called as though it is an array. What you guys want to actually call is lines._lines array within the object.

function unmount(node) { var index = node.data('index'); var line = lines[index]; var options = line[1]; if (is_function(options.unmount)) { options.unmount.call(self, node); } }

Change to:

function unmount(node) { var index = node.data('index'); var line = lines._lines[index]; var options = line[1]; if (is_function(options.unmount)) { options.unmount.call(self, node); } }

Expected behavior

When the Output limit exceeds the view it shouldnt throw an error, but rather clear the terminal.

Actual behavior

Steps to reproduce

In any jquery application, exceed the output limit by spamming some bogus codes. Itll eventually throw this error.

Browser and OS

Chrome, MacOS

Additional notes

[jcubic]

This is old code before lines were changed to Object. I've missed this place when refactored and the tests didn't catch that error because an error is not visible on the terminal and it's thrown with setTimeout (that is there to prevent infinite loops when printing errors on the terminal - or to prevent printing duplicated errors).