Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning image from interpreter doesn't pause the terminal #807

Closed
jcubic opened this issue Jul 12, 2022 · 0 comments
Closed

Returning image from interpreter doesn't pause the terminal #807

jcubic opened this issue Jul 12, 2022 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone
2.35.0

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 12, 2022

Issue summary

If you return a jQuery object with an image, the terminal is not paused while the image is loading.

Expected behavior

Terminal should pause

Actual behavior

The next prompt is available instantly.

Steps to reproduce

  1. Open https://codepen.io/jcubic/pen/JjLRGMr?editors=0010
  2. Compare command one and two

Browser and OS

NA
@jcubic jcubic added the Bug label Jul 12, 2022
@jcubic jcubic added this to the 2.35.0 milestone Jul 30, 2022
jcubic added a commit that referenced this issue Aug 5, 2022
@jcubic
pause terminal when returning images from from interpreter #807
eaa3a70
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Aug 5, 2022
@jcubic jcubic closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.35.0
Development

No branches or pull requests
1 participant
@jcubic