Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sixel rendering doesn't work anymore #824

Closed
jcubic opened this issue Sep 12, 2022 · 1 comment
Closed

Sixel rendering doesn't work anymore #824

jcubic opened this issue Sep 12, 2022 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone
2.35.0

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 12, 2022

Issue summary

The old demo with Sixel rendering doesn't work anymore

Expected behavior

It should render sixel image

Actual behavior

It doesn't render

Steps to reproduce

  1. Open CodePen demo
  2. It should render an image on load
@jcubic jcubic added the Bug label Sep 12, 2022
@jcubic
Copy link
Owner Author

jcubic commented Sep 12, 2022

It seems that renderHandler is receiving a promise instead of a string. And it throws an error that is swallowed.

jcubic added a commit that referenced this issue Sep 12, 2022
@jcubic
fix demo of rendering sixel images #824
7c48968
jcubic added a commit that referenced this issue Sep 12, 2022
@jcubic
fix handling promises in renderHandler #824
5ca9f2f
jcubic added a commit that referenced this issue Sep 12, 2022
@jcubic
fix lint errors #824
863e415
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Sep 12, 2022
@jcubic jcubic added this to the 2.35.0 milestone Sep 25, 2022
@jcubic jcubic closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.35.0
Development

No branches or pull requests
1 participant
@jcubic