Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target attribute to link #913

Closed
jcubic opened this issue Dec 30, 2023 · 1 comment
Closed

Add target attribute to link #913

jcubic opened this issue Dec 30, 2023 · 1 comment
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 30, 2023

I have an idea for a new feature for jQuery Terminal

On CodePen links should have target="top" so they open in new tab. It would be nice it XML formatted supports target.
@jcubic jcubic added the feature label Dec 30, 2023
jcubic added a commit that referenced this issue Apr 20, 2024
@jcubic
Don't force any attributes when using xml formatting #913
b90b736
@jcubic
Copy link
Owner Author

jcubic commented Apr 20, 2024

Adding all attributes into last arguments in formatting, allow adding any custom attribute, but it also don't enforce any default attribute. It was easier to implement, and it will be more intuitive.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 20, 2024
@jcubic jcubic closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic